fixnum deprecated warnings ref #55

danini-the-panini / mittsu

3D Graphics Library for Ruby.

https://github.com/danini-the-panini/mittsu

MIT License

510 stars 33 forks source link

fixnum deprecated warnings ref #55 #63

Closed nurettin closed 6 years ago

nurettin commented 6 years ago

I couldn't do a rake test because of a "couldn't find minitest/reporters" error, but I built the gem and ran the examples on ruby-2.3 and ruby-2.6.0.preview1 without deprecation warnings.

OK I did bundle exec rake test and saw the assert_nil messages, fixed the ones in #55 , but the one in mittsu/test/renderers/shaders/test_rbsl_loader.rb:167 might be problematic.

nurettin commented 6 years ago

Not sure what is wrong with circleci, doesn't it work out of the box?

danini-the-panini commented 6 years ago

@nurettin Looks like Homebrew got updated and stopped supporting the version of ruby that was being used. I've just gone ahead and upgraded the whole config to CircleCI 2.0 now so everything should work now

nurettin commented 6 years ago

@jellymann I updated the branch to master, it looks ready to merge. I removed lots of warnings.