search

danini / graph-cut-ransac

The Graph-Cut RANSAC algorithm proposed in paper: Daniel Barath and Jiri Matas; Graph-Cut RANSAC, Conference on Computer Vision and Pattern Recognition, 2018. It is available at http://openaccess.thecvf.com/content_cvpr_2018/papers/Barath_Graph-Cut_RANSAC_CVPR_2018_paper.pdf
Other
426 stars 92 forks source link

Support float/double image width and height #39

Open Parskatt opened 1 year ago

Parskatt commented 1 year ago

Hi,

Currently the python wrapper, see e.g. here:

https://github.com/danini/graph-cut-ransac/blob/37f7469d49dbedddeaa5a2c1427b70121375c0bd/src/pygcransac/src/gcransac_python.cpp#L721-L731

only supports integer image sizes.

As far as I can tell, these are always cast to doubles, so it would make sense to support arbitrary numbers.

In my use case I have modified the intrinsics, and hence the "virtual" image sizes become doubles. I'm unsure if rounding these to integers pose any issues to the RANSAC loop, so would prefer to insert the exact values.

Although reading the code it seems these only control neighbourhood sizes so I guess rounding shouldnt be a big issue.

Best, Johan

danini commented 1 year ago

Rounding should not cause any problem I think. The sizes are only used for specific samplers and for the neighborhood calculation.