search

danini / graph-cut-ransac

The Graph-Cut RANSAC algorithm proposed in paper: Daniel Barath and Jiri Matas; Graph-Cut RANSAC, Conference on Computer Vision and Pattern Recognition, 2018. It is available at http://openaccess.thecvf.com/content_cvpr_2018/papers/Barath_Graph-Cut_RANSAC_CVPR_2018_paper.pdf
Other
431 stars 93 forks source link

Hello, danini #5

Closed yangninghua closed 5 years ago

yangninghua commented 6 years ago

Hello, danini, in your engineering graph-cut-ransac, I found a mistake, but I can't solve it because I don't quite understand graph-cut-ransac, as shown below. u is a 14 matrix, but the program uses it over the boundary. F->at(0) u.at(3); F->at(3) u.at(4); F->at(6) u.at(5); image

yangninghua commented 6 years ago

fundamental_estimator.cpp

danini commented 6 years ago

A bit late answer, but thank you for pointing my attention to this bug! The problems was: u is supposed to be the point correspondence (x1 y1 1 x2 y2 1), but I removed the ones and did not changed this part of the code. I hope that it is okay now.

MathsionYang commented 5 years ago

i want to know how to solve it??

MathsionYang commented 5 years ago

Hello, danini, in your engineering graph-cut-ransac, I found a mistake, but I can't solve it because I don't quite understand graph-cut-ransac, as shown below. u is a 14 matrix, but the program uses it over the boundary. F->at(0) u.at(3); F->at(3) u.at(4); F->at(6) u.at(5); image

您好，怎么解决呢

lisongshi commented 5 years ago

i want to know how to solve it??

you may change the code in essential_estimator.h and fundamental_estimator.h like that: u.at(3) -> u.at(2); u.at(4) -> u.at(3); u.at(5) -> 1.0;

lisongshi commented 5 years ago

A bit late answer, but thank you for pointing my attention to this bug! The problems was: u is supposed to be the point correspondence (x1 y1 1 x2 y2 1), but I removed the ones and did not changed this part of the code. I hope that it is okay now.

thank you, danini, i have run it successfully in win whilst i have a issue that i could run it in linux with no change. it troubles me, may i have your proposal ? thanks a lot