search

danini / magsac

The MAGSAC algorithm for robust model fitting without using an inlier-outlier threshold
Other
415 stars 65 forks source link

MAGSAC is not updating the sampling? #27

Closed nicolaloi closed 1 year ago

nicolaloi commented 1 year ago

Hi, first of all thanks for your repository and pybindings.

Looking at the magsac.h file, it seems that there is no sampler update inside the while loop, while this was present in GRANSAC.h.

Is this intentional?'

Thank you.

danini commented 1 year ago

Good catch, thanks! It updates it now.