added black code formatter and github action to run linting for PR and push #65

danionescu0 / docker-flask-mongodb-example

Uses docker compose with a python flask microservice and MongoDB instance to make a sample application

GNU General Public License v3.0

99 stars 41 forks source link

added black code formatter and github action to run linting for PR and push #65 #66

Closed neelabalan closed 3 years ago

danionescu0 commented 3 years ago

It failed the lint on pull request

neelabalan commented 3 years ago

yeah I raised a PR with three commits only the last one has code formatted

neelabalan commented 3 years ago

the previous two commits failed the lint :)

neelabalan commented 3 years ago

the stresstest-locust directory doesn't seem to be formatted. I will why that happened and raise a PR for that

danionescu0 commented 3 years ago

Hmm that is a diffrent directory ment to be run in the linux console not in the containers. Maybe we should exclude it for now

neelabalan commented 3 years ago

yeah I've already done that in black.yml to check only tests/ and python/ but don't know why it is taking locust for format. I think I am doing it wrong. I am looking at another option to exclude only locust with black --check --exclude '/(stresstest-locusts)/' . which works locally but not in github actions. I am working on this now.