search

danionescu0 / docker-flask-mongodb-example

Uses docker compose with a python flask microservice and MongoDB instance to make a sample application
GNU General Public License v3.0
99 stars 41 forks source link

added functional tests for mqtt demo #20 #70

Closed neelabalan closed 3 years ago

neelabalan commented 3 years ago

are the new changes good?

danionescu0 commented 3 years ago

The last pushed changes are mine: https://github.com/danionescu0/docker-flask-mongodb-example/commit/c93e09610b85ced6911696d1fe89611db1e2749e (this commit) Have you pushed them ?

neelabalan commented 3 years ago

The last pushed changes are mine: c93e096 (this commit) Have you pushed them ?

yeah. I referred to this one for type hints. Didn't make changes on source file.

neelabalan commented 3 years ago

I synced up before adding test_mqtt.py

danionescu0 commented 3 years ago

oh, yes you cand make a PR

neelabalan commented 3 years ago

oh, yes you cand make a PR

did you mean I can't. If not I've already made the PR with the suggested changes

danionescu0 commented 3 years ago

i've merged it

neelabalan commented 3 years ago

i've merged it

I'll create a new PR and close previous one (if any changes suggested) going forward. It looks confusing.