search

danionita / e3tools

e3tool is a Java GUI-based tool for constructing and evaluating e3value models. Includes the e3fraud fraud assessment extension
Other
3 stars 4 forks source link

Sometimes "not a valid proportion is triggered" unnecessarily #33

Closed danionita closed 8 years ago

danionita commented 8 years ago

(e.g. 6666666666)

bobismijnnaam commented 8 years ago

So do we want to handle arbitrarily big integers, or do we just say "proportion too big" when this happens? (I'll go with the latter for now)

bobismijnnaam commented 8 years ago

Fixed as of e9eaaac624162c4619fda44ec4a6b0ac6a14c559.

danionita commented 8 years ago

Would be nice to make it somewhat more transparent to the user. Maybe change the warning message to "enter a number between x and y". Also, I think maybe we should support sub-unitary numbers too, as that's what users intuitively interpret "fraction" as.

On Jul 28, 2016 9:08 AM, "Bob Rubbens" notifications@github.com wrote:

So do we want to handle arbitrarily big integers, or do we just say "proportion too big" when this happens? (I'll go with the latter for now)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danionita/e3tools/issues/33#issuecomment-235816765, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjEpDnDgINDiRoZgbR7jOfJwmTV52TKks5qaFVVgaJpZM4JVD_J .