search

danionita / e3tools

e3tool is a Java GUI-based tool for constructing and evaluating e3value models. Includes the e3fraud fraud assessment extension
Other
3 stars 4 forks source link

Integrate legacy e3value functionality #55

Closed danionita closed 7 years ago

danionita commented 7 years ago

The following modules need to be broken off the old e3value tool and integrated into the new tool. Currently waiting for the developers of e3value to provide this code.

bobismijnnaam commented 7 years ago

Stuff I had to do before I got a sensible error message:

bobismijnnaam commented 7 years ago

Then I added valuations and value transactions and the simple test I implemented generated an excel sheet.

danionita commented 7 years ago

Do you mean to say that after you did all that, the NCF parsed the RDF correctly and completely? Does this mean it is fixed now or was this just a diagnosis? What is "the weird thing with the &'s in the rdf:RDF tag"?

On Sun, Oct 23, 2016 at 1:33 PM, Bob Rubbens notifications@github.com wrote:

Then I added valuations and value transactions and the simple test I implemented generated an excel sheet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danionita/e3tools/issues/55#issuecomment-255583605, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjEpCUqZKAjVjxyZkeJlJkTpgTOcm8zks5q20YagaJpZM4Js4td .

bobismijnnaam commented 7 years ago

This was all just to find an example of an rdf model that works. So yeah, a diagnosis I guess. And indeed after I did all that the NCF parsed the rdf completely. The RDF was still generated by the old editor though, not the new one.

The weird thing is the doctype declaration between the xml header and the rdf tag.

bobismijnnaam commented 7 years ago

The original editor exports a vt_has_fraction="1" property when you add value transactions. However our ontology does not have any vt_has_fraction property (that is, E3value.vt_has_fraction does not seem to exist). Should we add it by hand?

bobismijnnaam commented 7 years ago

Well, turns out Jaap's code barfs when the vt_has_fraction property is not present. So I'm just gonna add it now (ProfGenerator.java:2110)

bobismijnnaam commented 7 years ago

NCF module purrs without errors. No clue if the output is correct though (see slack for debug output & xls). As of: bdee35738f6f912c2ca0bcf851ddbdb257c4da30.

danionita commented 7 years ago

Somehow I missed these last updates. All looks good. The transaction editor (issue #90 should allow the user to change the vt_has_fraction property