search

danionita / e3tools

e3tool is a Java GUI-based tool for constructing and evaluating e3value models. Includes the e3fraud fraud assessment extension
Other
3 stars 4 forks source link

Bug in conversion from fraud to value #56

Closed bobismijnnaam closed 7 years ago

bobismijnnaam commented 7 years ago

When a model is converted from fraud to value with E3Graph's toValue() method, at the moment all hidden transfers are made unhidden. But should they instead be deleted? Since hidden transfers tend to be added by the fraud generation module, the original value model tends not to have them.

danionita commented 7 years ago

Indeed, hidden transfers should be removed, non-occurring transfers should be made occurring and colluding actors should be separated.

bobismijnnaam commented 7 years ago

Fixed as of 947a7ca2048dda25f2dfd002840f606afe6e3e0e.