danionita / e3tools

e3tool is a Java GUI-based tool for constructing and evaluating e3value models. Includes the e3fraud fraud assessment extension
Other
3 stars 4 forks source link

Feedback issues from Roel #61

Closed bobismijnnaam closed 8 years ago

bobismijnnaam commented 8 years ago

Some small issues on the current version;

  • When editing the e3fraud model (e.g. after right click and select fraud – colluding) it is not anymore possible to open the fraud generation window.

I think this has to do with the fact that his model was a fraud model, and analysis of a fraud model is disabled. At the moment a window appears asking if conversion to a value model is ok. If that's enough this problem is not a problem anymore.

  • It is annoying to users if they want to save (not save as) but always the dialog box pops up and again I have to parse through the directories to replace it. This is tough to frequently save updates.

I think @danionita implemented "file remembering" s.t. when you save to a file, the editor will keep saving to that file

  • Sometimes when I click to show the labels, it doubles the value object types – Like e.g. [Money][Money]

I fixed this some time ago, shouldn't be a problem.

  • I was trying to model the roaming scenario (see the attachment) but I could not generate scenarios because I can’t choose the main actor from the ‘fraud generation’ window. So I can’t evaluate the result neither.

This is because he only uses value activities. Somehow these don't show up in the fraud editor. This should either be documented in the wiki, and an error message when no actors are detected should be shown when the fraud window opens. Or we should just fix this s.t. value activities should also be able to be picked as root for the analysis (this depends on e3value semantics however).

So all in all this stuff should be easy to fix :)

danionita commented 8 years ago

Hi Bob,

I'm sorry, I though I already replied to this. I'm behind the Great Chinese Firewall so accessing my e-mail is very tricky and some e-mails don't seem to go through...

All your replies are on point. I've already explained points 1 and 4 to the tester. I will fix file remembering.

Best, Dan

On Sun, Sep 11, 2016 at 9:05 PM, Bob Rubbens notifications@github.com wrote:

Some small issues on the current version;

  • When editing the e3fraud model (e.g. after right click and select fraud – colluding) it is not anymore possible to open the fraud generation window.

I think this has to do with the fact that his model was a fraud model, and analysis of a fraud model is disabled. At the moment a window appears asking if conversion to a value model is ok. If that's enough this problem is not a problem anymore.

  • It is annoying to users if they want to save (not save as) but always the dialog box pops up and again I have to parse through the directories to replace it. This is tough to frequently save updates.

I think @danionita https://github.com/danionita implemented "file remembering" s.t. when you save to a file, the editor will keep saving to that file

  • Sometimes when I click to show the labels, it doubles the value object types – Like e.g. [Money][Money]

I fixed this some time ago, shouldn't be a problem.

  • I was trying to model the roaming scenario (see the attachment) but I could not generate scenarios because I can’t choose the main actor from the ‘fraud generation’ window. So I can’t evaluate the result neither.

This is because he only uses value activities. Somehow these don't show up in the fraud editor. This should either be documented in the wiki, and an error message when no actors are detected should be shown when the fraud window opens. Or we should just fix this s.t. value activities should also be able to be picked as root for the analysis (this depends on e3value semantics however).

So all in all this stuff should be easy to fix :)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/danionita/e3tools/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjEpFKbsGoI3Fofytst9CgJKPdi5rjFks5qo_yggaJpZM4J6ALE .