search

danionita / e3tools

e3tool is a Java GUI-based tool for constructing and evaluating e3value models. Includes the e3fraud fraud assessment extension
Other
3 stars 4 forks source link

(do not) Restrict protected attributes #68

Closed danionita closed 7 years ago

danionita commented 7 years ago

The user should not be able to:

bobismijnnaam commented 7 years ago

So on anything except start stimuli, there should not be an "OCCURRENCES" formula on the object?

bobismijnnaam commented 7 years ago

Implemented as of 48562426b6af8495ed45a6c2fba5d16453bf2487. Is this ok?

danionita commented 7 years ago

Great! I'll reopen this if I can think of others.

danionita commented 7 years ago

For some reason, endStimuli have OCCURRENCES attached to them. OCCURRENCES are only allowed on StartStimuli and Value Interfaces so this creates a deadlock when editing the properties of a endStimuli: one cannot close the window because there is an error thrown about OCCURRENCES being only attachable to startStimuli.

I suggest dropping this constraint to prevent further problems.

bobismijnnaam commented 7 years ago

I'm not sure which version you used, but in the version I just pulled the end stimuli don't have occurrences formulas. Did you maybe open an old model? Because it's almost guaranteed that old models still have the occurrences formula set, which breaks the editor. We can either drop this as you suggested or you'll have to doctor your models a bit (by opening them as a zip file and editing the xml file by hand).

Do you still want me to remove this feature? Because I think it's good to let the user know this way they can't have occurrences formulas.

danionita commented 7 years ago

Actually the only place I don't want occurrence formulas are value interfaces. Because they would get overwritten by the profitability computation. I think we should either only restrict value interfaces or none at all.

On Sun, Oct 30, 2016 at 11:12 AM, Bob Rubbens notifications@github.com wrote:

I'm not sure which version you used, but in the version I just pulled the end stimuli don't have occurrences formulas. Did you maybe open an old model? Because it's almost guaranteed that old models still have the occurrences formula set, which breaks the editor. We can either drop this as you suggested or you'll have to doctor your models a bit (by opening them as a zip file and editing the xml file by hand).

Do you still want me to remove this feature? Because I think it's good to let the user know this way they can't have occurrences formulas.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/danionita/e3tools/issues/68#issuecomment-257142584, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjEpOzBdeR8asVAlWEEc9E0y27r8NzHks5q5G2CgaJpZM4KNlXv .