search

danionita / e3tools

e3tool is a Java GUI-based tool for constructing and evaluating e3value models. Includes the e3fraud fraud assessment extension
Other
3 stars 4 forks source link

When opening a fraud model from the fraud generation module, hidden transfers do not receive IDs #76

Closed danionita closed 7 years ago

bobismijnnaam commented 7 years ago

If I open the default flat rate telephony example, do some fraud generation, open one with a hidden transaction, open it in the editor, and then inspect the properties of the hidden edge, it has an ID. So I'm not sure if I understand the issue correctly. Moreover, when the properties of this edge are inspected, and the user closes the window, the editor complains about propagation. Should maybe the valuations be propagated immediately after opening the model in the editor? If that is the case I need to edit some code, since this then should not be undo-able in my opinion either.

danionita commented 7 years ago

When I tried it yesterday it didn't work, but maybe I did something wrong or the commit yesterday fixed it. Anyway, yes the value should be automatically propagated to ports I think. Otherwise running a profitability analysis in the generated model will give weird results.

Best regards, Dan Ionita

On Oct 15, 2016 3:38 PM, "Bob Rubbens" notifications@github.com wrote:

If I open the default flat rate telephony example, do some fraud generation, open one with a hidden transaction, open it in the editor, and then inspect the properties of the hidden edge, it has an ID. So I'm not sure if I understand the issue correctly. Moreover, when the properties of this edge are inspected, and the user closes the window, the editor complains about propagation. Should maybe the valuations be propagated immediately after opening the model in the editor? If that is the case I need to edit some code, since this then should not be undo-able in my opinion either.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/danionita/e3tools/issues/76#issuecomment-253984791, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjEpGyeSlDTyBFRnNo42d9pfePfiek-ks5q0NdIgaJpZM4KXH25 .

bobismijnnaam commented 7 years ago

Huh, ok. Maybe show me next week what you did specifically and what it looked like?

I'll have a look at it and create a new issue.