search

danionita / e3tools

e3tool is a Java GUI-based tool for constructing and evaluating e3value models. Includes the e3fraud fraud assessment extension
Other
3 stars 4 forks source link

Allow connecting Value Activities to one another. #85

Closed danionita closed 7 years ago

bobismijnnaam commented 7 years ago

I'm not sure if that's a good idea. I remember that after some discussions with you and Jaap, it was decided that value activities can only connect to their "containing" entities. So if you have a VA within an MS/AC it can only connect to the MS or AC it is residing in. If you have a top-level VA it can connect to anything. There's also a comment stating specifically this. Did I interpret our discussions wrong or is this the way it should be?

danionita commented 7 years ago

I cannot come up with any reason not to allow it. Do you remember where that comment was?

There are at least two reasons to allow it:

On Sat, Dec 10, 2016 at 2:50 PM, Bob Rubbens notifications@github.com wrote:

I'm not sure if that's a good idea. I remember that after some discussions with you and Jaap, it was decided that value activities can only connect to their "containing" entities. So if you have a VA within an MS/AC it can only connect to the MS or AC it is residing in. If you have a top-level VA it can connect to anything. There's also a comment stating specifically this. Did I interpret our discussions wrong or is this the way it should be?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danionita/e3tools/issues/85#issuecomment-266209830, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjEpA5dfWLEP3IexdE4YxwGR5ttkkLHks5rGq42gaJpZM4K6i3m .

bobismijnnaam commented 7 years ago

Do you mean this figure?

image

I see only one value activity in that graph. Anyway, I think the reason why I thought that was because of #48. However #48 does not exclude value activities connecting with eachother, so we should probably allow that. I'll try implementing it today.

bobismijnnaam commented 7 years ago

Should work as of d4366c59959368716bd5564e0ca07eaa9cce5969.

bobismijnnaam commented 7 years ago

38cf8835299b25b445f49ad27c4704358eed2780 whoops.