search

danipen / TextMateSharp

A port of tm4e to bring TextMate grammars to dotnet ecosystem
MIT License
101 stars 19 forks source link

Use [Flags] enum for FontStyle #58

Closed Khitiara closed 10 months ago

Khitiara commented 10 months ago

TextMateSharp.Themes.FontStyle is currently a class with int fields representing a bitfield. This sort of bitfield is normally represented in c#/dotnet as an enum with the [Flags] attribute, so FontStyle should be updated to match.

danipen commented 10 months ago

Agree. The implementation is a port from tm4e so it matches that implementation. But there are some areas for improvement.

@Khitiara would you like to add a PR for this?

Khitiara commented 10 months ago

ill fork it and do it, this should be a relatively quick thing

danipen commented 10 months ago

Merged! Thanks for the contribution.