Use subprocess.run to run vale binary(#8)

daniperez / vale-python-package

Install 📝 Vale (grammar & style check tool ) in 🐍 Python environments. Package available at 📦 https://pypi.org/project/vale/

MIT License

8 stars 3 forks source link

Closed benallan closed 1 year ago

benallan commented 1 year ago

https://github.com/daniperez/vale-python-package/issues/8 execvp doesn't replace the active process on windows, so we use Popen and forward the return code instead.

daniperez commented 1 year ago

hi @benallan !

Your fix has been published to Pypi (vale version 2.25.0 or greater).

benallan commented 1 year ago

Great, thanks a lot for all your help @daniperez!