search

daniperez / vale-python-package

Install 📝 Vale (grammar & style check tool ) in 🐍 Python environments. Package available at 📦 https://pypi.org/project/vale/
MIT License
8 stars 3 forks source link

Fix windows binary .exe problem #9

Closed benallan closed 1 year ago

benallan commented 1 year ago

"Fixes" the issue where we can't run the vale binary on windows (#8 ).

However this adds a new "vale.exe" to the mainfest, which is not as clean than the original single vale_bin (which I assume was intended to be common to all platforms).

There might be other ways to deal with this, perhaps varying based on whether the user is running powershell or cmd.exe, but adding the .exe is probably the simplest solution.

I put this in a separate PR from #8 for now, since adding the .exe seems like a more invasive addition, but of course I'm happy to rearrange it however you prefer!

benallan commented 1 year ago

I'll close this because there are better solutions, e.g. #12.