search

danirabbit / nimbus

A minimal weather applet
GNU General Public License v2.0
80 stars 21 forks source link

incompatible with latest libgweather from GNOME 3.28 #70

Closed decathorpe closed 6 years ago

decathorpe commented 6 years ago

When compiling against the latest libraries from the GNOME 3.28 release, I get the following error messages:

FAILED: com.github.danrabbit.nimbus@exe/src/Application.c com.github.danrabbit.nimbus@exe/src/MainWindow.c 
valac -C --vapidir /builddir/build/BUILD/nimbus-0.2.0/vapi --pkg libgeoclue-2.0 --pkg gweather-3.0 --pkg gtk+-3.0 --pkg gobject-2.0 --pkg glib-2.0 --color=always --directory com.github.danrabbit.nimbus@exe --basedir ../ --gresources=../data/css.gresource.xml ../src/Application.vala ../src/MainWindow.vala
../src/MainWindow.vala:48.53-48.73: error: The name `ForecastType' does not exist in the context of `GWeather'
        weather_info = new GWeather.Info (location, GWeather.ForecastType.LIST);
                                                    ^^^^^^^^^^^^^^^^^^^^^
../src/MainWindow.vala:48.24-48.79: error: 1 extra arguments for `void GWeather.Info.new (GWeather.Location?)'
        weather_info = new GWeather.Info (location, GWeather.ForecastType.LIST);
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/MainWindow.vala:96.26-96.40: warning: Gtk.Dialog.get_action_area has been deprecated since 3.12
../src/Application.vala:49.9-49.23: warning: Gtk.Application.add_accelerator has been deprecated since 3.14
../src/Application.vala:61.9-61.32: warning: Gtk.Widget.state_changed has been deprecated since 3.0
Compilation failed: 2 error(s), 3 warning(s)
ninja: build stopped: subcommand failed.

Those are the dependency versions as found by meson:

Found pkg-config: /usr/bin/pkg-config (1.4.1)
Native dependency glib-2.0 found: YES 2.55.2
Configuring config.h using configuration
Native dependency glib-2.0 found: YES 2.55.2
Native dependency gobject-2.0 found: YES 2.55.2
Native dependency gtk+-3.0 found: YES 3.22.28
Native dependency gweather-3.0 found: YES 3.27.4
Native dependency libgeoclue-2.0 found: YES 2.4.7
danirabbit commented 6 years ago

It looks like in the latest version of GWeather, Info only takes location as an argument. Changing this now would break Loki though, so needs a conditional compile

danirabbit commented 6 years ago

Should be fixed in master