feat. format json on response body tab

[devLuisDonaldo]

First of all, i'm sorry

I need to say that i am not a rust/gtk dev, maybe I shouldn't do this

Sometimes responses json type dont format correctly on body panel

for that i applied some lines for try render a bit better json values

I'm not sure if this help or improve performance with long single line

• [x] add serde_json dependency
• [x] format response with to_string_pretty fn
• [x] set the format to panel

i really apreciate any type of feedback and tips, or if I can help you in other ways i'll do it with pleasure

pd: i like yout content, you do a great job

[danirod]

Okay, first of all, thank you so much for adding this feature. I had been told that prettifying the JSON document was necessary because JSON documents that are minified are difficult to read and even cause performance issues if they are too long. So this will be very helpful.

I believe, however, that the way the body is probed to check if it is a JSON document may be non-exhaustive:

https://github.com/danirod/cartero/blob/9194960aa60ace06dbd402b01c5e4c74fd37af1f/src/widgets/response_panel.rs#L263

Specifically, I see two downsides here:

• It misses some JSON types such as arrays. (To be fair, primitive JSON types like string or number can also be documents themselves, so true is technically also a JSON document).
• It may mark as JSON some raw bodies that are not JSON but that start and end with { } anyway. The only example I can imagine right now is an endpoint that returns a GraphQL query that uses GraphQL syntax, as they still are enclosed in brackets but they are not JSON documents.

A more concise test may be to check whether the response has a Content-Type header that is of JSON type. Something like "does the header contains /json or contains +json?" That should catch content-types like application/json, text/json and application/vnd.github.raw+json (which is still JSON).

I am just talking and haven't checked whether this compiles, but it should be possible to get the content-type via the Response struct, and then checking if there is a header there that contains +json or /json.

if let let Some(type) = resp.headers.header("Content-Type") {
  if type[0].contains("+json") || type[0].contains("/json") {
    // Is JSON
  }
}

I was planning on releasing 0.1 today. I can patch it after work and let the 0.1 release already have this feature. However, if you want to change it by yourself, it's fine.

[devLuisDonaldo]

Thank you for the observations. I wanted to apply your validations, but I was working, and maybe I would have been wrong. I saw your stream, and I need to practice more to understand how this works Certainly, your streams teach like it was a course

BTW, congratulations for the release