search

daniruiz / flat-remix-gnome

Flat Remix is a GNOME Shell theme inspired by material design. It is mostly flat using a colorful palette with some shadows, highlights, and gradients for some depth.
http://drasite.com/flat-remix-gnome
Creative Commons Attribution Share Alike 4.0 International
1.59k stars 108 forks source link

Fix visibility of dropdown/pop-menu parent items #207

Closed ttytm closed 1 year ago

ttytm commented 2 years ago

Currently, using a dark variant, opening a dropdown in a pop menu results in bad visibility of the parent menu item (with a dark panel theme) or invisibly (when using a darkest theme). It uses the same dark color as the light theme, but on a dark background. Here is a quick example of the current state.

https://user-images.githubusercontent.com/34311583/183301684-aef48322-0ccc-46d8-8097-17a9ef498698.mp4

In contrast, the light theme:

flat-remix-light

This commit fixes by applying the active item font color to those parent elements. Result:

flat-remix-dark

Additionally, a duplicate CSS selector that was declared twice in the block of the added style property was merged.

ttytm commented 2 years ago

The change of background color for the darkest panels must have slipped my gaze. I thought I properly split that replace action for both panel variants. Only the color property should have been added next to merging the duplicate selector. I'll correct that when I have a free moment today.

daniruiz commented 1 year ago

Sorry but you're using an old version of gnome. Since gnome 43 the menus are different

ttytm commented 1 year ago

It's not that I'm using an old version of gonme the PR was just made before gnome 43 👍

daniruiz commented 1 year ago

Si, sorry I wan't too clear. It's just that it's no longer the latest version, so I'm focused on gnome 44 now. Sorry for the delay :cry: