daniruiz / flat-remix-gtk

Flat Remix is a GTK application theme inspired by material design. It is mostly flat using a colorful palette with some shadows, highlights, and gradients for some depth.
https://drasite.com/flat-remix-gtk
GNU General Public License v3.0
861 stars 70 forks source link

Unnecessary thick dark border around window #126

Closed Trikenstein closed 3 years ago

Trikenstein commented 3 years ago

Using dark solid theme, released on 2021-10-30. I think the tick dark border surrounding the window is un-necessary. Especially on unfocused windows.

daniruiz commented 3 years ago

What border do you refer to? Can you send a screenshot with an example?

Trikenstein commented 3 years ago

Hi sorry,

Would you be OK to consider re-opening this issue? Was a bit busy lately.

Here is a screenshot showing the tick borders. This becomes particularly visible when I add a colored titlebar by adding this at the bottom of ~/.themes/Flat-Remix-GTK-Teal-Dark-Solid\gtk.css

.titlebar, headerbar {
  background-color: #126670;
}
.titlebar:backdrop, headerbar:backdrop {
  background-color: #0b3f46;
}

Granted the colored titlebar is not part of the initial design. But still, do you think the thick border design is still relevant?

FlatRemix_Dark_ThickBorders

daniruiz commented 3 years ago

Hi there, I closed this issue because I thought you were talking about the shadow on non-focused windows like in https://github.com/daniruiz/flat-remix-gtk/issues/127

My issue with that border is that it is a trick to be able to round bottom corners of windows that are not rounded by default. Otherwise the previous square corner overflows the window image

One thing I can do is remove the top border color, as that one is not required for this trick

But I'll still need the side borders

Another option would be using a border with the same background-color and transparency as the headerbar: image

daniruiz commented 3 years ago

I've done a mix of the changes I suggested. Now all themes are update so you can test them. Tell me if that works for you. I really think this is a good improvement, so thanks for reporting it ;)

Trikenstein commented 3 years ago

same background-color and transparency as the headerbar

Personally I think this one is the best. Thanks you very much for taking care of the request.