daniruiz / flat-remix

Flat Remix is an icon theme inspired by material design. It is mostly flat using a colorful palette with some shadows, highlights, and gradients for some depth.
http://drasite.com/flat-remix
GNU General Public License v3.0
1.69k stars 110 forks source link

Add some missing icons uncovered by gnome-shell 3.36.1 #142

Closed terencode closed 3 years ago

terencode commented 4 years ago

When updating to gnome-shell 3.36.1 from 3.36.0, the following commit was included:

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1127/diffs?commit_id=c89d6a633aa431adda8080665e38d957146c5357

This made gnome-shell show the "image-missing" icon when it cannot find the given one.

This makes one of my menu a bit ugly because the extension was relying on using a 'blank' icon to get the spacing right probably : image

It seems this extension (https://github.com/kgshank/gse-sound-output-device-chooser) is the only one I could find that used this 'blank' icon workaround so unless you know this icon is somehow standard, the fix shouldn't come from you. I opened an issue about it here: https://github.com/kgshank/gse-sound-output-device-chooser/issues/95

However, I found the following are used by appindicators (https://github.com/ubuntu/gnome-shell-extension-appindicator) and seems to be rather common:

terencode commented 4 years ago

It's probably a matter of symlinks.

Example of an appindicator with missing icons: image

daniruiz commented 3 years ago

Is this still happening? I'm not able to reproduce it

terencode commented 3 years ago

This seems fixed indeed.