search

danirus / django-comments-xtd

A pluggable Django comments application with thread support, follow-up notifications, mail confirmation, like/dislike flags, moderation, a ReactJS plugin and Bootstrap 5.3.
https://django-comments-xtd.readthedocs.io
BSD 2-Clause "Simplified" License
594 stars 158 forks source link

Errors until I installed django-avatar application - is it required? #188

Closed jimkring closed 4 years ago

jimkring commented 4 years ago

I noticed that I was getting errors until I installed django-avatar. Is this supposed to be a requirement of django_comments_xtd? If so, it should probably be included in the installation / getting started documents. Thanks!

danirus commented 4 years ago

No, django-avatar is not a requirement. If you can reproduce the issue, please, post it here and I'll look into it.

jimkring commented 4 years ago

I tried to reproduce this, but I cannot. I think I caused this error. Thanks for letting me know.

jimkring commented 4 years ago

I just reproduced the issue, I think -- it happens when I try to post a comment.

Inside of preview.html it loads avatar_tags (on line 3):

django_comments_xtd/templates/comments/preview.html

{% extends "django_comments_xtd/base.html" %}
{% load i18n %}
{% load avatar_tags %}
{% load comments_xtd %}
 
{% block title %}{% trans "Preview your comment" %}{% endblock %}
 
{% block content %}
<div class="container">
<div class="mb-4">
<h3 class="text-center">{% trans "Preview your comment" %}</h3>
<hr/>
</div>
jimkring commented 4 years ago

It seems like I can work around this by copying this template over into my project and then removing that {% load avatar_tags %} line -- everything seems to work OK without it, which means it was probably left over from some experimentation or creating a demo.

danirus commented 4 years ago

That's a bug. I added it by mistake a few days ago while writing the docs. Thanks for the catch!

danirus commented 4 years ago

This bug has been fixed already and will be released as part of v.2.7.1. Thanks again @jimkring for the quick catch!