search

danirus / django-comments-xtd

A pluggable Django comments application with thread support, follow-up notifications, mail confirmation, like/dislike flags, moderation, a ReactJS plugin and Bootstrap 5.3.
https://django-comments-xtd.readthedocs.io
BSD 2-Clause "Simplified" License
595 stars 158 forks source link

Installation from repository with pip installs older version #337

Closed PetrDlouhy closed 2 years ago

PetrDlouhy commented 2 years ago

I am trying to install the project with:

pip install git+https://github.com/danirus/django-comments-xtd#egg=django-comments-xtd

But it ends up installing older versions of PyPI packages: django-comments-xtd-2.3.1, Django-2.2.24 and old DRF.

This is really veird behavior - seems like it has django-comments-xtd dependency on itself. I am trying to figure out what is really happening. One problem, that I found is the old version 2.3.1 set in header of pyproject.toml file. But I don't know why is this taken as a dependency.

danirus commented 2 years ago

Yes, the pyproject.toml file is outdated. Another developer kindly added it and I forgot to update it since then.

PetrDlouhy commented 2 years ago

I don't think, that the outdated pyproject.toml is the only problem. I had to erase it completely, because otherwise PIP would install the current PyPI version of django-comments-xtd, but I wanted to install from repository with my changes. I don't know, why PIP does that, but it is very confusing.

danirus commented 2 years ago

26d1d9f05c443446cdb001169865424189996f49 resolves this issue.

danirus commented 2 years ago

This was fixed more than six months ago... If it happens again, please, don't hesitate to reopen.