fix to enable using UUIDs/non-default PKs

danirus / django-comments-xtd

A pluggable Django comments application with thread support, follow-up notifications, mail confirmation, like/dislike flags, moderation, a ReactJS plugin and Bootstrap 5.3.

https://django-comments-xtd.readthedocs.io

BSD 2-Clause "Simplified" License

595 stars 158 forks source link

fix to enable using UUIDs/non-default PKs #342

Closed PetrDlouhy closed 1 year ago

PetrDlouhy commented 2 years ago

I tried to use UUIDs as PKs as mentioned in #179, and the only problem preventing that was these two small misuses of ID instead of PK.

PetrDlouhy commented 2 years ago

@danirus I have rebased this PR to current master nad added a test case for commentbox_props_respons() (which was untested until now).

This is very simple change which fixes #179 (with exception of Proxy models) and should be harmless otherwise.

PetrDlouhy commented 1 year ago

The changes in the core code code contained in this PR are overridden by #374, although the new tests should be still valid and work with the new code there.