search

danirus / django-comments-xtd

A pluggable Django comments application with thread support, follow-up notifications, mail confirmation, like/dislike flags, moderation, a ReactJS plugin and Bootstrap 5.3.
https://django-comments-xtd.readthedocs.io
BSD 2-Clause "Simplified" License
595 stars 158 forks source link

add ordering filter to the API #409

Closed PetrDlouhy closed 5 months ago

PetrDlouhy commented 6 months ago

This is only ordering added to API which is extracted from #364. It didn't seem to be problem on that PR, so I hope this could be merged while the rest needs discussion.

danirus commented 6 months ago

Yes, it could be added, but please, move the filter_backends property to the CommentList view. CommentCreateView, CommentCount, ToggleFeedbackFlag and CreateReportFlag don't need ordering capabilities. Just CommentList can benefit from it.

PetrDlouhy commented 5 months ago

@danirus OK, I moved it.

danirus commented 5 months ago

Thanks @PetrDlouhy