danirus / django-comments-xtd

A pluggable Django comments application with thread support, follow-up notifications, mail confirmation, like/dislike flags, moderation, a ReactJS plugin and Bootstrap 5.3.
https://django-comments-xtd.readthedocs.io
BSD 2-Clause "Simplified" License
595 stars 158 forks source link

remarkable as optionable #414

Open Mte90 opened 5 months ago

Mte90 commented 5 months ago

If I don't care about the markdown support I get from the JS bundle in this project:

Uncaught ReferenceError: remarkable is not defined
    <anonymous> http://127.0.0.1:8000/static/django_comments_xtd/js/django-comments-xtd-2.9.13.js:1330
danirus commented 5 months ago

How do you propose to do it optional?

Mte90 commented 5 months ago

I didn't still checked the JS code but I think that should be enough check if the remarkable object exists and in that case execute the code.