search

danirus / django-comments-xtd

A pluggable Django comments application with thread support, follow-up notifications, mail confirmation, like/dislike flags, moderation, a ReactJS plugin and Bootstrap 5.3.
https://django-comments-xtd.readthedocs.io
BSD 2-Clause "Simplified" License
594 stars 157 forks source link

Some options from COMMENTS_XTD_APP_MODEL_OPTIONS are not honored #423

Closed gamboz closed 6 months ago

gamboz commented 6 months ago

If I add to my django settings the variable COMMENTS_XTD_APP_MODEL_OPTIONS as follows,

COMMENTS_XTD_APP_MODEL_OPTIONS = {
    "myapp.somemodel": {
        "allow_feedback": True,
        ...

the options "allow_feedback" and others are ignored in when building the "props" by django_comments_xtd.api.frontend.CommentBoxDriver (e.g. here).

If I understand correctly this documentation, the lines for the four options defined by default in utils.get_app_model_options (here) should read something like "allow_flagging": options['allow_flagging'],

This issue should be solved by https://github.com/danirus/django-comments-xtd/pull/422

gamboz commented 6 months ago

This has already been addressed in https://github.com/danirus/django-comments-xtd/tree/rel-3.0.0

And development seems to be here: https://pypi.org/project/django-comments-ink/

I'm closing this issue :slightly_smiling_face: