search

danisheddie / pe

0 stars 0 forks source link

Return index flaw for addbar #4

Open danisheddie opened 4 years ago

danisheddie commented 4 years ago

image.png

Says that i have 3 bars in "hello" but there's ony one.

nus-pe-bot commented 4 years ago

Team's Response

Before using and testing the commands, the tester did not read the description of the view command in the User Guide . Please refer to page 5 of the User Guide. For convenience, the relevant extract from the User Guide is displayed by the screenshot below.

Relevant extract of the View Command from the Ducats - User Guide: image.png

From the extract, we observe that the User Guide clearly states that the view command only displays the last bar of the song the user specifies. Therefore, the behaviour of the string of commands shown above is in fact the expected behaviour. The previous bar of the song is definitely not deleted after a new bar was added.

Further breakdown is as follows:

  1. The user's input is: view hello. Ducat's displays the visual representation of the last bar of the song, "hello".

  2. The user's input is: addbar 1_UA. Ducat's adds the new bar of 1 whole note at the pitch of Upper A to the song, "hello".

  3. The user's input is: view hello. Ducat's displays the visual representation of the last bar of "hello" again. This time, the last bar is the new bar that was just added by the addbar command before (whole note of Upper A). As demonstrated by the tester's screenshots, the commands are working as stated in the User Guide. The tester should have used the ascii command to have a visual representation of the entire song.

The bug type of this issue is changed from FeatureFlaw to FunctionalityBug as well. This is because if this issue is valid, it is an obvious flaw in how Ducats work instead a simple missing functionality.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue type

Team chose [type.FunctionalityBug]. Originally [type.FeatureFlaw].

Reason for disagreement: [replace this with your reason]