search

danisheddie / pe

0 stars 0 forks source link

Groupings does not reflected after sedning command to group the bars. #6

Open danisheddie opened 4 years ago

danisheddie commented 4 years ago

image.png

After grouping, the bars still ook the same. Perhaps UG can be clearer.

App is very hard to use for begginners who have no background knowledge of music composition

nus-pe-bot commented 4 years ago

Team's Response

Here's the documentation for the view command (note that view command only shows the last bar of the current song):

image.png

Here, I've a song called jingle (notice that view command only shows the last bar of the song):

image.png

Next, let me group 2 and 4 as sunlight just as you did:

image.png

Here, I've grouped bars 2 to 4 as sunlight. By calling the command "list_group", you will be able to see all the groups present in the song. By invoking the command "ascii group sunglight", you can see what this group comprises of.

I believe you thought that group will merge all these bars into 1.

Here's the excerpt of the group command from the user guide:

image.png

Here, I've beginned off the paragraph with, "In music, repetition of tunes and rhythms are very common. The group command allows users to efficiently save tunes and rhythms for each of their songs. The user can group a continuous range of bars between two indices (inclusive) in the song track and give a name to this group."

From this we can understand that group merely takes a continuous range of bars from the group and saves this snippet. Hence, the user guide is clear. Furthermore, you can use "ascii group GROUP_NAME" command to visualise the group.

As this is clearly the intended behavior of Ducats, we reject this as a bug.

Furthermore, Ducats does support overlaying one bar onto another using different variations of the overlay command. You may refer to the overlay section of the user guide for more information.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: i feel that this should be stated clear in the user guide that ascii command needs to be called after groupings. This is especially useful for beginners or people whol has no background knowledge in music composition.