danisheddie / pe

0 stars 0 forks source link

editbar command sent excepption even when format was correct #8

Open danisheddie opened 4 years ago

danisheddie commented 4 years ago

image.png

exception was sent and it was also a wrong exception. I put an "index" but it was read as a string

nus-pe-bot commented 4 years ago

Team's Response

After multiple tries, this issue cannot be reproduced. Please look at the screenshot below.

Screenshot of attempts to mimic the tester's exception message: image.png The exception message returned shown in this screenshot is valid and is the intended behaviour for Ducats.

Following the tester's screenshot of an extract from the User Guide, it is seen that the User Guide clearly and explicity stated that "The new bar consists of notes specified by you and its total duration adds up to one beat."

The tester's input consists of one whole note of Upper B and one whole note of Upper A. That is a total duration of two beats. As such, Ducats should and did correctly return an exception telling the user that the bar cannot be edited due to invalid input.

Thus, if the exception message shown in the screenshot cannot be reproduced, this issue is to be rejected as the exception is the expected and correct behaviour for Ducats.

If the exception message of "The index must be a number not a string" can be reproduced, the severity of it should be Low as the message definitely does not affect normal operations and causes minor inconveniences only. The bug type is also believe to be switched to DocumentationBug as it is a flaw in a message that potentially confuses users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low]. Originally [severity.High].

Reason for disagreement: [replace this with your reason]


:question: Issue type

Team chose [type.DocumentationBug]. Originally [type.FeatureFlaw].

Reason for disagreement: [replace this with your reason]