search

danisheddie / pe

0 stars 0 forks source link

swapbar function not working #9

Open danisheddie opened 4 years ago

danisheddie commented 4 years ago

image.png

It says that it has swapped however when viewing the barrs, the bars are still the same after swapping.

nus-pe-bot commented 4 years ago

Team's Response

This issue is similar to issue #815. However, this issue is specifically referring the swapbar command instead of the addbar command. As such, this issue is not considered to be a duplicate, but similar explanation is given below to explain why the tester's screenshot above is actually Ducat's expected behaviour.

Before using and testing the commands, the tester did not read the description of the view command from the User Guide. Please refer to page 5 of the User Guide for the description of the view command. For convenience, the relevant extract from the User Guide is displayed by the screenshot below.

Relevant extract of the View Command from the Ducats - User Guide: image.png

From the extract, we observe that the User Guide clearly states that the view command only displays the last bar of the song the user specifies. When the view command is first called by the tester, the last bar of song "hello" is indeed displayed. Afterwards, the tester entered: swapbar 1 4. Next, if the tester used the ascii command to see the full visual representation of the entire song, he/she would have seen the swap between bars 1 and 4.

Screenshot of swapbar command working through the ascii command display: image.png

Even if the user were to use the view command, the effects of swapbar can still be observed if one of the bars being swapped is the last bar of the song. Please refer to the screenshots below. (As much as possible, the inputs are kept the same as the tester's)

Screenshots of swapbar command working through view command: image.png

image.png

Therefore, the swapbar command is working as intended.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.Low]. Originally [severity.High].

Reason for disagreement: [replace this with your reason]