search

danishm / mritopng

A simple python module to make it easy to batch convert DICOM files to PNG images.
MIT License
141 stars 50 forks source link

Failed conversion should not create a png file #7

Closed danishm closed 5 years ago

danishm commented 6 years ago

Actual: When converting a folder structure, a failed conversion still produces an empty png file. Expected: There should be no png file for failed conversions

kshitij12345 commented 6 years ago

Can I take the issue?

danishm commented 5 years ago

@kshitij12345 I know it's been over a year since you posted "Can I take the issue?". Have you already fixed this?

kshitij12345 commented 5 years ago

I believe I have. Will start a PR.

danishm commented 5 years ago

@kshitij12345 PR looks mostly good, just requested a simple change on it.

danishm commented 5 years ago

Thank you @kshitij12345 !