search

danishprakash / vim-zen

Barebones Vim Plugin Manager
MIT License
63 stars 3 forks source link

Remove commands library for Python 3 #12

Closed cassegfault closed 2 years ago

cassegfault commented 6 years ago

The commands library has been removed in Python 3 (see the docs). For the sake of consistent behavior, I have replaced the call to the commands library with the code called by the commands library.

cassegfault commented 6 years ago

Hey danish, will see if I can switch it over at some point. If you check out the code that I liked above, the commands library actually was calling those os commands directly. I agree using a subprocess is a better implentation

danishprakash commented 6 years ago

If you check out the code that I liked above, the commands library actually was calling those os commands directly.

You're right but, correct me If I'm wrong here, isn't this similar to using the os module? Anyway, as you said, It'd make much more sense If we jump over to subprocess for this.