search

danishzayan / YourQuotes-App

YourQuotes is a user friendly and an eye catching App. User can post your qutoes without login and that user can delete YourQuotes not from other user. User can share quotes with friend, copy to clipboard and do download gradient quotes image..
https://your-quotess.netlify.app/
MIT License
9 stars 38 forks source link

bug #15

Closed Kunal-deve1oper closed 1 month ago

Kunal-deve1oper commented 1 year ago

deleting the quote that I wrote but its not getting deleted from the api. the deleted quote appears again when i refresh the page.

danishzayan commented 1 year ago

deleting the quote that I wrote but its not getting deleted from the api. the deleted quote appears again when i refresh the page.

@Kunal-deve1oper Ok now you can work on this issue...

Kunal-deve1oper commented 1 year ago

deleting the quote that I wrote but its not getting deleted from the api. the deleted quote appears again when i refresh the page.

@Kunal-deve1oper Ok now you can work on this issue...

@danishzayan I am not able to fix the problem as the api is changing the "id" to some unique sequential number and not storing the "ID" we are giving . So its not deleting the data we want to . I think the problem is of the api

Siddharth9890 commented 1 year ago

Can you assign to me i take a look at it

danishzayan commented 1 year ago

Can you assign to me i take a look at it

@Siddharth9890 ok you can this task ..

Siddharth9890 commented 1 year ago

Your-Quotes.webm I have tried to resolve the issue please take a look also i would suggest to use try catch and use of async in code base to improve the code functionality

Siddharth9890 commented 1 year ago

So can i raise a PR

danishzayan commented 1 year ago

So can i raise a PR

ok after testing i will merge your code

danishzayan commented 1 year ago

What is method to go can you explain..

@Siddharth9890 I want that the quotes should be deleted from the system of whose mobile or system only the quotes are posted. Your posted quotes should not be deleted from other's system or mobile.

danishzayan commented 1 year ago

@Siddharth9890 And when someone else deletes it from their mobile then alert should come that "this is not your qutoes"

danishzayan commented 1 year ago

@Siddharth9890 for this method you can store system info and that match from match system info if this is your system then delete otherwise this is not ur qutoes...