search

danishzayan / YourQuotes-App

YourQuotes is a user friendly and an eye catching App. User can post your qutoes without login and that user can delete YourQuotes not from other user. User can share quotes with friend, copy to clipboard and do download gradient quotes image..
https://your-quotess.netlify.app/
MIT License
11 stars 39 forks source link

Remove "type to add your-quotes" post card #7

Closed danishzayan closed 1 year ago

danishzayan commented 1 year ago

Remove "type to add your-quotes" post card after that Add plus icon on the bottom-right-corner and when user click on plus icon a popup should be open for posting qutoes..

mritul commented 1 year ago

Hey ! Can I work on this issue ?

danishzayan commented 1 year ago

@mritul You can work on this issue.. 😊😊😊

JatinSingh08 commented 1 year ago

Hey @danishzayan please assign this to me.

danishzayan commented 1 year ago

Hey @danishzayan please assign this to me.

@JatinSingh08 you can work on this issue 😊

mritul commented 1 year ago

@danishzayan I'm uploading the screenshots of the changes done. If it's fine I can raise a PR

danishzayan commented 1 year ago

@danishzayan I'm uploading the screenshots of the changes done. If it's fine I can raise a PR

@mritul ok I will do.

mritul commented 1 year ago

ss1

On opening popup

ss2

After adding the YourQuote

ss3

mritul commented 1 year ago

@danishzayan I've implemented such that the user now has to click the plus button on the bottom right to open a popup that helps them add a YourQuote

danishzayan commented 1 year ago

@danishzayan I've implemented such that the user now has to click the plus button on the bottom right to open a popup that helps them add a YourQuote

@mritul good I like it your work ❤️ create a PR i will merge you code...

mritul commented 1 year ago

@danishzayan That's great ! I've raised a PR .

danishzayan commented 1 year ago

@danishzayan That's great ! I've raised a PR .

193441157-3ae1aeb5-814b-4b21-b2a0-ae5b08f62af7 @mritul 1) when will open so popup has overlay transparent color... 2) when user click in app anywhere so popup should be close.. 3) fixed design so that popup looks good.. fix all this issue.. sure after that i will merge your code...

danishzayan commented 1 year ago

@mritul Really you done great work 💗

mritul commented 1 year ago

@danishzayan That's great ! I've raised a PR .

193441157-3ae1aeb5-814b-4b21-b2a0-ae5b08f62af7 @mritul

  1. when will open so popup has overlay transparent color...
  2. when user click in app anywhere so popup should be close..
  3. fixed design so that popup looks good.. fix all this issue.. sure after that i will merge your code...

Sure I'll work on it

mritul commented 1 year ago

@danishzayan I've implemented all the requested changes and I couldn't implement a black overlay but still implemented a white toned overlay. Hope it's fine with you. It would be great if you merged the PR with the hacktoberfest-accepted tag once you're satisfied with the performed changes. Thank you ❤️