Missing Keycodes for F13-F24

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. install a 5250 client (tn5250)
2. connect to a mainframe
3. try to send F24 by holding shift and pressing F12

What is the expected output? What do you see instead?
Should send F24 keycode, but garbage is sent instead (not really garbage, but 
not the right keycode).

What version of the product are you using? On what operating system?
latest version running on Ubuntu

Please provide any additional information below.

F13 through F24 need to be defined in ShellInABox.js

Original issue reported on code.google.com by mrw...@gmail.com on 8 Mar 2012 at 9:36

GoogleCodeExporter commented 8 years ago

Patches welcome.

Original comment by beewoo...@gmail.com on 31 Mar 2012 at 11:29

GoogleCodeExporter commented 8 years ago

The keycodes for F13-F24 are below.  They need to be added to the block 
starting at line 2676 in vt100.js:

     else if (event.shiftKey && !event.ctrlKey &&
               !event.altKey && !event.metaKey) {
      switch (key) {

However, the logic following these blocks, staring around line 2765:

     if (event.shiftKey || event.ctrlKey || event.altKey || event.metaKey)

causes issues with these keycodes - it mangles them.  Looking at the code I'm 
not really sure why its there or what it's doing, so maybe someone can 
enlighten me?  Commenting it out seemed to have to noticeable effect on the 
limited tests I did.  I attached a diff for the first change, adding the 
keycodes.  However, due to my unfamiliarity with the project as a whole, I'm 
not sure if removing the second block of code will cause any problems.  To me 
it seems redundant and unneeded, but maybe I'm missing something?

Original comment by phobo...@gmail.com on 20 Jun 2012 at 5:10

Attachments:

danito / shellinabox

Missing Keycodes for F13-F24 #168