search

danjac / django-saas-starter

Opinionated Django project cookiecutter
Other
37 stars 10 forks source link

improvement: prettier mirrors #1

Closed 0bserver07 closed 3 years ago

0bserver07 commented 3 years ago

thank you, this is cool. I have been cooking up a template using similar layout, but with Flask.

After testing your version, I came across an error for prettier within the pre-commit, maybe swap out the source:

Basically changing:

https://github.com/danjac/django-saas-starter/blob/d774676e49f9a52b0eba8ee4b0f350a023297a1d/%7B%7Bcookiecutter.project_slug%7D%7D/.pre-commit-config.yaml#L16-L20

to:

  - repo: https://github.com/awebdeveloper/pre-commit-prettier
    rev: ''
    hooks:
      - id: prettier
        exclude: 'templates/|mockups/|README.md'

if you are having similar issues about pre-commit error, I can do a PR and change this part.

danjac commented 3 years ago

Interesting: not seen this error but will try and replicate.

danjac commented 3 years ago

Updated with https://github.com/awebdeveloper/pre-commit-prettier.