Coordinates as input for regions

danjgale / nii-masker

Convenient command-line wrapper for nilearn's Masker objects

BSD 3-Clause "New" or "Revised" License

7 stars 3 forks source link

Coordinates as input for regions #18

Closed danjgale closed 4 years ago

danjgale commented 4 years ago

Addresses #17.

Brings a breaking change from previous versions where the old mask_img now is roi_file. Now, the current mask_img is the extra mask that NiftiSpheresMasker and NiftiLabelsMasker can take it to constrain extraction. Don't know why I didn't think of this earlier...

Everything seems to work when tested locally. Needs a proper test suite in due time.

danjgale commented 4 years ago

Coordinates might require its own module in the future, given how many changes this involved. Made me realize how much this project could benefit from mapping out a redesign under the hood...

danjgale commented 4 years ago

Going to also document here that coordinate based atlases that can be fetched in nilearn are currently not supported. This is the next step to add in a separate PR