search

danjgale / surfplot

A package for publication-ready brain surface figures
https://surfplot.readthedocs.io/en/latest/
Other
53 stars 14 forks source link

add alpha parameter #14

Closed harrisonritz closed 1 year ago

harrisonritz commented 2 years ago

takes argument for colormap opacity. Will break if alpha < 0, but doc + error is informative.

danjgale commented 1 year ago

Hey @harrisonritz I'm finally getting around to this, and have spotted a few bugs that need fixes. Given that you submitted this awhile ago, if it's alright with you I can just add in the fixes directly to this PR rather than reviewing + requesting changes. Would save you time instead of making you revisit the whole thing and have you add fixes. Lmk

harrisonritz commented 1 year ago

Sweet! Ya, feel free to add yourself, don’t need to keep me in the loop.

Harrison

From: Dan Gale @.> Date: Monday, December 19, 2022 at 12:19 PM To: danjgale/surfplot @.> Cc: Harrison Ritz @.>, Mention @.> Subject: Re: [danjgale/surfplot] add alpha parameter (PR #14)

Hey @harrisonritzhttps://github.com/harrisonritz I'm finally getting around to this, and have spotted a few bugs that need fixes. Given that you submitted this awhile ago, if it's alright with you I can just add in the fixes directly to this PR rather than reviewing + making you add them. Lmk

— Reply to this email directly, view it on GitHubhttps://github.com/danjgale/surfplot/pull/14#issuecomment-1357990616, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEDVTHZBAOOXGF6GTEEAMX3WOCKJZANCNFSM5RUKGDSA. You are receiving this because you were mentioned.Message ID: @.***>

danjgale commented 1 year ago

Great thanks! Can you click "Allow edits from maintainers"?

harrisonritz commented 1 year ago

looks like this is checked already.

danjgale commented 1 year ago

All looks good now. Thanks for your contribution @harrisonritz!

harrisonritz commented 1 year ago

np! sorry for being shit at python haha the colons kill me