Improve the overall performance of the plugin

danjono / Inventory-Rollback

Allows server moderators to restore player items and data from backups.

MIT License

35 stars 20 forks source link

Improve the overall performance of the plugin #38

Open md5sha256 opened 4 years ago

md5sha256 commented 4 years ago

This PR intends to improve performance of the plugin significantly,

Changes:

Cached reflection calls in NBT
Async loading / saving of inventories
Cleaned up some code formatting for readability
Add PaperLib as a dependency, utilize async chunk loading when teleporting players where possible.

md5sha256 commented 4 years ago

I've yet to test this, will do so tomorrow; Leaving this open for "review"

Aurelien30000 commented 3 years ago

@md5sha256 Do you allow me to includes your changes into my own fork and share them, in such a way that the jar file is downloadable and usable? Thanks!

md5sha256 commented 3 years ago

Sure, although I would advise more extensive testing. This is currently on use on a production server and there do not seem to be issues.

Strahilchu commented 3 years ago

Need this!

Aurelien30000 commented 3 years ago

Need this!

https://github.com/Aurelien30000/Inventory-Rollback/releases/tag/1.5.0 Feel free to use my own that includes this.

All the other changes I made are about code format and "logic", so don't worry ;)

Aurelien30000 commented 3 years ago

Sure, although I would advise more extensive testing. This is currently on use on a production server and there do not seem to be issues.

Right, two small issues fixed here (NPEs) https://github.com/Aurelien30000/Inventory-Rollback/commit/8c5281ba2e90af1cd66879181b141744f3adfc5f ^^

Romvnly-Gaming commented 3 years ago

Any updates on this?

Aurelien30000 commented 3 years ago

Not especially, go to my github page and download it from the actions page if you wanna use it ;)