dank074 / Discord-video-stream

Experiment for making video streaming work for discord selfbots.
183 stars 35 forks source link

Conflicting dependencies #86

Closed dank074 closed 7 months ago

dank074 commented 7 months ago

Since https://github.com/dank074/Discord-video-stream/pull/84 it seems npm install fails with:

npm ERR! While resolving: prism-media@1.3.5
npm ERR! Found: opusscript@0.1.1
npm ERR! node_modules/opusscript
npm ERR!   opusscript@"^0.1.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional opusscript@"^0.0.8" from prism-media@1.3.5
npm ERR! node_modules/prism-media
npm ERR!   prism-media@"^1.3.5" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: opusscript@0.0.8
npm ERR! node_modules/opusscript
npm ERR!   peerOptional opusscript@"^0.0.8" from prism-media@1.3.5
npm ERR!   node_modules/prism-media
npm ERR!     prism-media@"^1.3.5" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Should we downgrade opusscript to "opusscript": "^0.0.8", until https://github.com/amishshah/prism-media updates their dependencies?

longnguyen2004 commented 7 months ago

Does adding

"overrides": {
    "prism-media": {
      "opusscript": "$opusscript"
    }
  }

into package.json work?

Also, sorry for not catching the issue, I was using pnpm for everything 😅

dank074 commented 7 months ago
"overrides": {
    "prism-media": {
      "opusscript": "$opusscript"
    }
  }

That worked, will do this thanks!