search

dankamongmen / growlight

notcurses block device manager / system installation tool
https://nick-black.com/dankwiki/index.php/Growlight
GNU General Public License v3.0
85 stars 12 forks source link

segfault when pressing f1 #102

Closed dankamongmen closed 3 years ago

dankamongmen commented 3 years ago

Debian bug #974888 reports a reliable segfault when pressing F1. This is pretty embarrassing, so let's get it knocked out ASAP.

dankamongmen commented 3 years ago

I think this is all coming from #99, where we moved away from known-good recursive locks. I'm gonna check -- I can readily reproduce this.

dankamongmen commented 3 years ago

F1 now loads the help menu, though I couldn't reproduce this crash reported in the DBTS. We were, however, seeing crashes due to #103, which might be the problem he was running into (hopefully?).

xtaran commented 3 years ago

Well, yes, f3261dd did indeed fix it for pressing F1, but the problem persists with pressing F2 to F12 for me. See my reply on the Debian bug report for details. So I guess this is a "reopen". :-/

dankamongmen commented 3 years ago

Indeed it is. @xtaran provided one of the all-time great bug reports over in DBTS, and I intend to chase down the rest of the issues mentioned there.

I've fixed up your segfault on shutdown in #106 -- I'm pretty sure it'll handle that issue.

Actually, I'm going to close this back up, and make new issues for tracking the rest of your reported woes. Thank you so much for taking a patient look at growlight! I completely replaced its UI backend earlier this year (NCURSES -> notcurses) over the course of two days, and a number of things are shaking out.

xtaran commented 3 years ago

I completely replaced its UI backend earlier this year (NCURSES -> notcurses) over the course of two days, and a number of things are shaking out.

Ah, this explains why the UI of a years-old tool made a rather rough impression. Thanks for sharing that detail!