dankamongmen / growlight

notcurses block device manager / system installation tool
https://nick-black.com/dankwiki/index.php/Growlight
GNU General Public License v3.0
85 stars 12 forks source link

mkfs.ext4 is being called with bad -b argument #120

Closed dankamongmen closed 3 years ago

dankamongmen commented 3 years ago
 550932 pts/0    S+     0:00                  |       |   \_ sudo ./growlight
 550933 pts/0    Sl+    0:00                  |       |       \_ ./growlight
 550981 pts/0    S+     0:00                  |       |           \_ sh -c mkfs.ext4 -b -2048 -L "survivor" -O dir_index,extent /dev/sdc1 2>&1 < /dev/null
 550982 pts/0    D+     0:00                  |       |               \_ mkfs.ext4 -b -2048 -L survivor -O dir_index,extent /dev/sdc1
 551192 pts/1    Ss     0:00                  |       \_ bash

what is this -b -2048 business? we just want -b 2048.

dankamongmen commented 3 years ago

Nevermind, that's valid:

  If  block-
              size  is preceded by a negative sign ('-'), then mke2fs will use
              heuristics to determine the appropriate  block  size,  with  the
              constraint  that  the  block  size  will  be at least block-size
              bytes.  This is useful for certain hardware  devices  which  re‐
              quire that the blocksize be a multiple of 2k.