dankamongmen / growlight

notcurses block device manager / system installation tool
https://nick-black.com/dankwiki/index.php/Growlight
GNU General Public License v3.0
85 stars 12 forks source link

growlight-readline crashes when stdout is redirected #140

Closed dankamongmen closed 3 years ago

dankamongmen commented 3 years ago

UGH. 1.3.29 with 2.2.1. embarrassing, so so embarrassing.

note that this happens when stdout is redirected, not stdin, though the problem is when we call into readline() (which indeed oughtn't be used in non-interactive sessions).

dankamongmen commented 3 years ago

I think to do this right, we've got to avoid using notcurses on any path where we're not a tty. We're still getting failures due to an inability to initialize notcurses in debian autopkgtests even with 1.2.30:

https://ci.debian.net/data/autopkgtest/testing/amd64/g/growlight/10506095/log.gz https://tracker.debian.org/pkg/growlight