dankamongmen / growlight

notcurses block device manager / system installation tool
https://nick-black.com/dankwiki/index.php/Growlight
GNU General Public License v3.0
84 stars 12 forks source link

misleading diagnostic printed on failure #152

Closed dankamongmen closed 2 years ago

dankamongmen commented 2 years ago

I'm seeing a lot of this with 1.2.37:

virtfs fuse.lxcfs at /proc/swaps
Couldn't read link at /sys/class/block/lxcfs (No such file or directory)
virtfs fuse.lxcfs at /proc/uptime
Couldn't read link at /sys/class/block/cgroup2 (No such file or directory)
virtfs cgroup2 at /sys/fs/cgroup
Couldn't read link at /sys/class/block/hugetlbfs (No such file or directory)
virtfs hugetlbfs at /dev/hugepages
Couldn't read link at /sys/class/block/mqueue (No such file or directory)
virtfs mqueue at /dev/mqueue
Couldn't read link at /sys/class/block/none (No such file or directory)
Error parsing /proc/swaps
Couldn't set up notcurses

and then a failure. weirdly enough, we also see Returning 0 though we're clearly not?

Killing the event thread...
Shutting down udev monitor...
Freeing devtable...
Closing libpci...
Returning 0...
autopkgtest [16:11:35]: test blockdev: -----------------------]
autopkgtest [16:11:35]: test blockdev:  - - - - - - - - - - results - - - - - - - - - -
blockdev             FAIL non-zero exit status 1
autopkgtest [16:11:35]: @@@@@@@@@@@@@@@@@@@@ summary
blockdev             FAIL non-zero exit status 1
dankamongmen commented 2 years ago

nah, that's not why they're failing. they're failing because they can't initialize notcurses, which ought be fixed by my having inserted a TERM export just now.

why the returning 0, though?

dankamongmen commented 2 years ago

fixed