dankamongmen / growlight

notcurses block device manager / system installation tool
https://nick-black.com/dankwiki/index.php/Growlight
GNU General Public License v3.0
85 stars 12 forks source link

debian autopkgtests fail with timeout #153

Closed dankamongmen closed 2 years ago

dankamongmen commented 2 years ago

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=997845

we function properly, but never seem to exit. not sure exactly what's going on here.

dankamongmen commented 2 years ago

the move to 1.2.38 + notcurses 3 didn't end up resolving this at all =[

dankamongmen commented 2 years ago

so there seem to be two major possibilities:

it seems to me that the latter really ought be detectable based off logs, if we give them a close analysis. didn't we add this autopkgtest from the very beginning? did it only recently begin failing? let's take a look at that, also.

dankamongmen commented 2 years ago

ok, i've been able to reproduce this via

echo "blockdev -v" | sudo TERM=xterm-256color growlight-readline -v

dankamongmen commented 2 years ago

so growlight-readline is using direct mode...

dankamongmen commented 2 years ago

ok we're failing to initialize when given input from a non-terminal:

process_escape:1871:walk result on 49 (1): 0 273
process_escape:1871:walk result on 51 (3): 0 273
process_escape:1871:walk result on 50 (2): 0 273
geom_cb:607:cell geom report 64/132
process_escape:1871:walk result on 116 (t): 2 274
process_escape:1859:initialized automaton to 1
process_escape:1871:walk result on 91 ([): 0 4
process_escape:1871:walk result on 63 (?): 0 304
process_escape:1871:walk result on 54 (6): 0 335
process_escape:1871:walk result on 50 (2): 0 305
process_escape:1871:walk result on 59 (;): 0 346
da1_attrs_cb:1068:read primary device attributes
da1_attrs_cb:1071:DA1: 62 []
process_escape:1871:walk result on 99 (c): 1 347
block_on_input:2126:blocking on input availability
block_on_input:2171:output queues full; blocking on ipipes
block_on_input:2183:waiting on 2 fds (ibuf: 0/8192)

this looks like a notcurses problem.

dankamongmen commented 2 years ago

ok, no changes needed here; https://github.com/dankamongmen/notcurses/issues/2496 resolves this issue:

[schwarzgerat](0) $ echo "blockdev -v" | sudo LD_LIBRARY_PATH=/usr/local/lib growlight-readline -v
....
md126p1    63b849c3-5190-4487-9999-1b88e9de0f6f   2.00T Lnx Linux filesystem
n/a               ext4  c0319829-05fc-48e8-9ac3-b51696388dc0 md126p   1.97T
 /media/vm rw,relatime
Unused sectors 3906762847:3906762880 (17Ki)
md127      Linux mdadm       1.2 106.23G  512B VM... none  root             NVMe
n/a               ext4  939be09a-b63d-403c-996a-8b9866313fbb md127  104.03G
 / rw,noatime,errors=remount-ro

    Flags:  (R)emovable, (U)nloaded, (V)irtual, (M)dadm, (Z)pool, 
        (D)M, r(O)tational, (r)ead-only, (W)ritecache enabled, 
        (B)IOS bootable, v/⚠: Read-Write-Verify, ✓/✗/☠: SMART status
[growlight](0)> 
Killing the event thread...
Shutting down udev monitor...
Freeing devtable...
Closing libpci...
Returning 0...