dankamongmen / growlight

notcurses block device manager / system installation tool

https://nick-black.com/dankwiki/index.php/Growlight

GNU General Public License v3.0

85 stars 12 forks source link

Add disk stats to readline UI #20

Closed dankamongmen closed 5 years ago

dankamongmen commented 5 years ago

5 addresses how to integrate disk activity statistics with the curses UI, but we also ought expose them in our readline UI. Since there's no regular display update here, they'd need be explicit. I'd say....

include blockdev stats in the blockdev detail command
include partition stats in the partition detail command, if it's ever written
add a stats command to the toplevel

dankamongmen commented 5 years ago

It's rudimentary, but it's working, using the new stats command. growlight-readline-stats

dankamongmen commented 5 years ago

As I note in #18, we're making the stats a part of the growlight core, so this will be duplicating that functionality. It shouldn't mess with what we have here, though (we can keep an internal and external set of deltas, and the kernel provides only absolute counts).

dankamongmen commented 5 years ago

I've changed the stats command to use the new dev model from #18, much better. Just need to add the detail now.

dankamongmen commented 5 years ago

Done! It could use polishing, but it's there.