search

dankamongmen / growlight

notcurses block device manager / system installation tool
https://nick-black.com/dankwiki/index.php/Growlight
GNU General Public License v3.0
85 stars 12 forks source link

Devices are showing up as "removable" when they most certainly are not #48

Closed dankamongmen closed 4 years ago

dankamongmen commented 4 years ago

Seeing this on killermike, using growlight 1.1.1-pre.

╭──────[nvme-0 [0] (32Gbps to Southbridge, 32Gbps (100%) demanded)]────────[-]─╮
│    nvme0n1┌─⇗⇨⇨⇨nvme0n1p1───────────────────────────────────────────────────┐│
│✔solidstate│m1113333 linux_raid_member “debian:intel 750 nvme” (378.61G) 333m││
│30°  no i/o└┤INTEL SSDPE2MW40  n/a 400.08G  512B gpt   CVCQ5135007B400C NVMe├┘│
╰─────[PCI Express device 0000:09.00.0 (x4, gen 3.0)]──────────────────────────╯

╭──────[ahci-0 (256Gbps to Southbridge, 12Gbps (4%) demanded)]─────────────[-]─╮
│        sdb┌─────────────────────────────────────────────────────────────────┐│
│✔ removable│me11111111111111111111 btrfs “butters” (12T) 1111111111111111111m││
│30°  no i/o└┤ST12000NM0007-2A SN02  12.00T 4096B gpt   5000c500b408015d SAT3├┘│
│        sdc┌─────────────────────────────────────────────────────────────────┐│
│✔ removable│me1 ext4 at / 1233333333333 ext4 at /home (199.96G) 33333333333em││
│30°  no i/o└┤Samsung SSD 840  6B0Q 256.06G  512B gpt   50025385a02983fa SAT3├┘│
╰─────[PCI Express device 0000:08.00.0 (x16, gen 4.0)]─────────────────────────╯

╭──────[ahci-1 (256Gbps to Southbridge, 6Gbps (2%) demanded)]──────────────[-]─╮
│        sda┌─────────────────────────────────────────────────────────────────┐│
│✔ removable│me11111111111111111 btrfs at /media/store (12T) 1111111111111111m││
│32°  no i/o└┤ST12000NM0007-2A SN02  12.00T 4096B gpt   5000c500b4b8415d SAT3├┘│
╰─────[PCI Express device 0000:07.00.0 (x16, gen 4.0)]─────────────────────────╯
dankamongmen commented 4 years ago

Same deal in readline:

[growlight](-1)> blockdev
Device     Model             Rev   Bytes PSect Flags Table WWN              PHY 
sda        ST12000NM0007-2A SN02  12.00T 4096B ROW⚠. gpt   5000c500b4b8415d SAT3
sdb        ST12000NM0007-2A SN02  12.00T 4096B ROW⚠. gpt   5000c500b408015d SAT3
sdc        Samsung SSD 840  6B0Q 256.06G  512B R.W⚠. gpt   50025385a02983fa SAT3
nvme0n1    INTEL SSDPE2MW40  n/a 400.08G  512B ✔.... gpt   CVCQ5135007B400C NVMe

    Flags:  (R)emovable, (U)nloaded, (V)irtual, (M)dadm, (Z)pool,
        (D)M, r(O)tational, (r)ead-only, (W)ritecache enabled,
        (B)IOS bootable, v/⚠: Read-Write-Verify, ✓/✗/☠: SMART status
[growlight](0)>
dankamongmen commented 4 years ago

Well, it's not our bug, per se:

[killermike](0) $ cat /sys/block/sdb/removable 
1
[killermike](0) $

did this change semantic recently, or did we change our handling of it? Or have we always displayed this on killermike, and I've never noticed it? The last seems hard to believe. I think I have some screenshots in earlier bugs...

dankamongmen commented 4 years ago

Huh! See #36 -- 2019-08-28 definitely shows "removable" on killermike. I do have these set to hotplug in the UEFI, but I have them set that way on all my machines, hrmm...confirmed that none on schwarzgerat show up as removable.

I guess just make this lower priority than "solidstate" or a rotation speed?

dankamongmen commented 4 years ago

OK, the rotation speed 1rpm as resulted by the kernel is our best indicator for solidstate. When we get this value (now aliased to SSD_ROTATION), we prioritize that over removable. We default to an empty string, rather than the old (unintentional?) default of solidstate. This seems much more sane. Testing on killermike shortly.

dankamongmen commented 4 years ago 
╭──────[nvme-0 [0] (32Gbps to Southbridge, 32Gbps (100%) demanded)]────────[-]─╮
│    nvme0n1┌─⇗⇨⇨⇨nvme0n1p1───────────────────────────────────────────────────┐│
│✔solidstate│m1113333 linux_raid_member “debian:intel 750 nvme” (378.61G) 333m││
│34°  no i/o└┤INTEL SSDPE2MW40  n/a 400.08G  512B gpt   CVCQ5135007B400C NVMe├┘│
╰─────[PCI Express device 0000:09.00.0 (x4, gen 3.0)]──────────────────────────╯

╭──────[ahci-0 (256Gbps to Southbridge, 12Gbps (4%) demanded)]─────────────[-]─╮
│        sdb┌─────────────────────────────────────────────────────────────────┐│
│✔  7200 rpm│me111111111111111111 btrfs “butters” (12.00T) 111111111111111111m││
│38°  no i/o└┤ST12000NM0007-2A SN02  12.00T 4096B gpt   5000c500b408015d SAT3├┘│
│        sdc┌─────────────────────────────────────────────────────────────────┐│
│✔solidstate│me1 ext4 at / 1233333333333 ext4 at /home (199.96G) 33333333333em││
│32°  no i/o└┤Samsung SSD 840  6B0Q 256.06G  512B gpt   50025385a02983fa SAT3├┘│
╰─────[PCI Express device 0000:08.00.0 (x16, gen 4.0)]─────────────────────────╯

╭──────[ahci-1 (256Gbps to Southbridge, 6Gbps (2%) demanded)]──────────────[-]─╮
│        sda┌─────────────────────────────────────────────────────────────────┐│
│✔  7200 rpm│me111111111111111 btrfs at /media/store (12.00T) 111111111111111m││
│38°  no i/o└┤ST12000NM0007-2A SN02  12.00T 4096B gpt   5000c500b4b8415d SAT3├┘│
╰─────[PCI Express device 0000:07.00.0 (x16, gen 4.0)]─────────────────────────╯

fixed!