dankamongmen / growlight

notcurses block device manager / system installation tool
https://nick-black.com/dankwiki/index.php/Growlight
GNU General Public License v3.0
85 stars 12 forks source link

growlight isn't drawing until we move over a device #75

Closed dankamongmen closed 4 years ago

dankamongmen commented 4 years ago

When I start the notcurses growlight (1.2.0, notcurses 1.1.1), I get no drawing until I actively do things:

2020-01-28-223128_722x1417_scrot

dankamongmen commented 4 years ago

I think this is a notcurses problem, as I haven't made any changes to growlight recently that would cause this.

dankamongmen commented 4 years ago

Actually, everything is getting drawn, but then when we're done, the screen is getting erased. We see everything again when we exit the program. Odd.

dankamongmen commented 4 years ago

If I tag up ncplane_create() with diagnostics, we see:

 [schwarzgerat](0) $ cat e
Term: 80x74 xterm-256color (xterm with 256 colors)
NEW ONE 74/80 + 0/0
NEW ONE 5/19 + 68/0
NEW ONE 73/80 + 0/0
NEW ONE 73/80 + 0/0
NEW ONE 2/80 + 13/0
NEW ONE 2/80 + 19/0
NEW ONE 2/80 + 25/0
NEW ONE 2/80 + 33/0
NEW ONE 2/80 + 42/0
NEW ONE 2/80 + 48/0
NEW ONE 5/20 + 68/0

that last one looks suspicious

dankamongmen commented 4 years ago

that's rows/cols/yoff/xoff btw

dankamongmen commented 4 years ago

If I run against notcurses-1.1.0, this doesn't happen. It does if I run against notcurses-1.1.1.

dankamongmen commented 4 years ago

The issue hinges on when we emit smcup.

dankamongmen commented 4 years ago

This is fixed by requiring notcurses 1.1.2+.