dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.61k stars 113 forks source link

only redraw damaged portions of sixels #2380

Open dankamongmen opened 2 years ago

dankamongmen commented 2 years ago

Horrifying, and very distressing that no one reported this. Playing nctetris in foot or XTerm sees input seemingly stop coming in after any kind of lengthy keypress (i.e. holding "down"). Ugh! =\

dankamongmen commented 2 years ago

and i can't seem to reproduce this in notcurses-input. maybe it's somehow an nctetris problem? that would be nice.

dankamongmen commented 2 years ago

hah, no, they're just playing slow as ass due to redrawing the entire sprixel each time, which by the way is insane -- why aren't we just redrawing the damaged portions? did we once do so? the vast majority of this image is never changing, but we redraw the entire screen like a jabroni.

alright, very interesting. let's dial nctetris's background back to 3x2 for the moment. we need speed this up. here again, there is the eternal question: do we wait for mosaics, or do this now?

there's the secondary question, about which we already have a bug, about not redrawing unchanged areas of multiframe graphics. but that's a distinct thing. this is about a single frame that is disrupted by other garbage.

dankamongmen commented 2 years ago

we're not getting this done in 3.0.